Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

SNOW-756525 Add changelog check in CI #1476

Merged
merged 4 commits into from
Mar 15, 2023
Merged

SNOW-756525 Add changelog check in CI #1476

merged 4 commits into from
Mar 15, 2023

Conversation

sfc-gh-stan
Copy link
Contributor

@sfc-gh-stan sfc-gh-stan commented Mar 14, 2023 •
edited
Loading

Please answer these questions before submitting your pull requests. Thanks!

  1. What GitHub issue is this PR addressing? Make sure that there is an accompanying issue to your PR.

    Fixes #SNOW-756525

  2. Fill out the following pre-review checklist:

    • I am adding a new automated test(s) to verify correctness of my new code
    • I am adding new logging messages
    • I am adding a new telemetry message
    • I am modifying authorization mechanisms
    • I am adding new credentials
    • I am modifying OCSP code
    • I am adding a new dependency

  3. Please describe how your code solves the related issue.

    Add a Github workflow that skips/passes if (1) a PR is labeled NO-CHANGELOG-UPDATES OR (2) if the PR modifies CHANGELOG.md.

@sfc-gh-stan sfc-gh-stan added the NO-CHANGELOG-UPDATES This pull request does not need to update CHANGELOG.md label Mar 14, 2023
@sfc-gh-stan sfc-gh-stan requested review from a team, sfc-gh-yixie and sfc-gh-evandenberg and removed request for a team March 14, 2023 17:56
@sfc-gh-stan sfc-gh-stan marked this pull request as ready for review March 14, 2023 17:56
sfc-gh-sfan
sfc-gh-sfan requested changes Mar 14, 2023
View reviewed changes
.github/workflows/changelog.yml Outdated Show resolved Hide resolved
@codecov-commenter
Copy link

codecov-commenter commented Mar 14, 2023 •
edited by codecov bot
Loading

Codecov Report

Merging #1476 (f6527cb) into main (277d744) will increase coverage by 0.02%.
The diff coverage is n/a.

❗ Current head f6527cb differs from pull request most recent head 454eb49. Consider uploading reports for the commit 454eb49 to get more accurate results

@@            Coverage Diff             @@
##             main    #1476      +/-   ##
==========================================
+ Coverage   81.87%   81.90%   +0.02%     
==========================================
  Files          60       60              
  Lines        8597     8597              
  Branches     1271     1271              
==========================================
+ Hits         7039     7041       +2     
+ Misses       1225     1223       -2     
  Partials      333      333

see 2 files with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@sfc-gh-stan sfc-gh-stan enabled auto-merge (squash) March 15, 2023 22:28
@sfc-gh-stan sfc-gh-stan merged commit 1b437d5 into main Mar 15, 2023
@sfc-gh-stan sfc-gh-stan deleted the add-changelog-check branch March 15, 2023 22:47
@github-actions github-actions bot locked and limited conversation to collaborators Mar 15, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@sfc-gh-sfan sfc-gh-sfan sfc-gh-sfan approved these changes

@sfc-gh-yixie sfc-gh-yixie Awaiting requested review from sfc-gh-yixie sfc-gh-yixie was automatically assigned from snowflakedb/snowpark-python-api

@sfc-gh-evandenberg sfc-gh-evandenberg Awaiting requested review from sfc-gh-evandenberg sfc-gh-evandenberg was automatically assigned from snowflakedb/snowpark-python-api

Assignees
No one assigned
Labels
NO-CHANGELOG-UPDATES This pull request does not need to update CHANGELOG.md
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@sfc-gh-stan @codecov-commenter @sfc-gh-sfan